[rfc][icedtea-web] bringing applets out of browser (part2)

[Jiri Vanek]

On 12/22/2014 10:02 AM, Jiri Vanek wrote:
> On 12/19/2014 04:39 PM, Jie Kang wrote:
>>
>>
>> ----- Original Message -----
>>>
>>>>> +                   move[0] ++;
>>>>> +                }
>>>>>
>>>>> Biggest nit here: Please refactor this into multiple functions (at least
>>>>> 1).
>>>>
>>>>
>>>> Something like:
>>>>
>>>> if (optionParser.hasOption(OptionsDefinitions.OPTIONS.HTML)) {
>>>>       bootAsHtml(...)
>>>> } else {
>>>>       [...]
>>>> }
>>>>
>>>> private void bootAsHtml(...) {
>>>>       [...]
>>>> }
>>>>
>>>>>
>>>>>
>>>>> +            return null;
>>>
>>> Please snip replies like this. I now hoep I have not overlooked something.
>>>
>>> Anyway - your nit fixed - thank you for forcing me - I have moved those boot*
>>> impls to separate
>>> classes. Much better.
>>>
>>> In adition this changeset contaisn also splash support during applets
>>> loading.
>>
>> Hello,
>>
>> Looks great! +1
>>
>>
>>
>> However, one thing, slightly related to patch:
>>
>> I tried:
>>
>> ./javaws -html http://centra.tecnico.ulisboa.pt/~amaro/Spline3D.html
>>
>> This worked great! Except I saw:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
>>     at javax.swing.MultiUIDefaults.getUIError(MultiUIDefaults.java:130)
>>     at javax.swing.UIDefaults.getUI(UIDefaults.java:762)
>>     at javax.swing.UIManager.getUI(UIManager.java:1016)
>>     at javax.swing.JPanel.updateUI(JPanel.java:126)
>>     at javax.swing.JPanel.<init>(JPanel.java:86)
>>     at javax.swing.JPanel.<init>(JPanel.java:109)
>>     at javax.swing.JPanel.<init>(JPanel.java:117)
>>     at javax.swing.JRootPane.createGlassPane(JRootPane.java:546)
>>     at javax.swing.JRootPane.<init>(JRootPane.java:366)
>>     at javax.swing.JDialog.createRootPane(JDialog.java:667)
>>     at javax.swing.JDialog.dialogInit(JDialog.java:648)
>>     at javax.swing.JDialog.<init>(JDialog.java:279)
>>     at javax.swing.JDialog.<init>(JDialog.java:206)
>>     at javax.swing.JDialog.<init>(JDialog.java:154)
>>     at net.sourceforge.jnlp.JNLPSplashScreen.<init>(JNLPSplashScreen.java:74)
>>     at net.sourceforge.jnlp.runtime.HtmlBoot$1.run(HtmlBoot.java:118)
>>     at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:744)
>>     at java.awt.EventQueue.access$400(EventQueue.java:97)
>>     at java.awt.EventQueue$3.run(EventQueue.java:697)
>>     at java.awt.EventQueue$3.run(EventQueue.java:691)
>>     at java.security.AccessController.doPrivileged(Native Method)
>>     at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:714)
>>     at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
>>     at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
>>     at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
>>     at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
>>     at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
>>     at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
>>
>> I do not think this is our fault and might be related to:
>> https://bugs.openjdk.java.net/browse/JDK-6919529
>>
>> But they aren't exactly the same and I am not sure; any ideas?
>>
>> The applet still worked fine though :)
>>
>
>
> hmhm. It wokrkes for me without this error (mate, jdk8)

Wrong testing changeset. Yes. With splasshcreen on the NPE really can occur...



I had:

Applet panel net.sourceforge.jnlp.NetxPanel[panel0,0,0,600x600,layout=java.awt.BorderLayout] initialized
Init complete
LiveGraphics3D caught exception in initialize():
    java.lang.NullPointerException
LiveGraphics3D tries to initialize once more...
LiveGraphics3D 1.90 by Martin_Kraus_Germany at yahoo.com
Exception in thread "Thread-9" java.lang.NullPointerException
	at Live.initialize(Live.java:497)
	at Live.run(Live.java:1996)
	at java.lang.Thread.run(Thread.java:745)



^CRelease shared lock on /tmp/jvanek/netx/locks/netx_running
No other instances of netx are running




And the exeption was fatal. Maybe my -html impl is missing some wait-until-init?


Btw -  I do not see java -splash during ITW boots now - Do you not-see the same?
>
>
> Isnt this the issue with look&feel Lukas was trying to reproduce?
>
>
> Thank you for review!
>
> Pushing.
>
>    J.
>