[rfc][icedtea-web] Refactor initialize/download out of ResourceTracker and add tests

[Lukasz Dracz]

Hello,

The code looks good !

I just have a few small nits

+        CodeWithRedirect result = new CodeWithRedirect();




----- Original Message -----
> From: "Jie Kang" <jkang at redhat.com>
> To: "IcedTea Distro List" <distro-pkg-dev at openjdk.java.net>
> Sent: Tuesday, December 30, 2014 3:17:23 PM
> Subject: [rfc][icedtea-web] Refactor initialize/download out of	ResourceTracker and add tests
> 
> Hello,
> 
> The attached patch moves the download/initialize runnable into a separate
> class named ResourceDownloader. The tests applicable to the new
> ResourceDownloader have also been moved from ResourceTrackerTest to
> ResourceDownloaderTest.
> 
> As well a number of tests have been added to ResourceDownloaderTest in order
> to ensure the capabilities of the downloader are maintained.
> 
> 
> New tests of note:
> 
> testDownloadResource
> testDownloadPackGzResource
> testDownloadVersionedResource
> testDownloadVersionedPackGzResource
> testDownloadLocalResourceFails
> testDownloadNotExistingResourceFails
> 
> There are two cases that I will add in a separate patch:
> 
> 1 : test redownloading using new setting in TinyHttpdImpl
> 2 : test download of gzip file (not packgz)
> 
> These both need extra work in code outside of ResourceDownloader
> 
> 
> How does it look?
> 
> 
> Regards,
> 
> --
> 
> Jie Kang