[rfc][icedtea-web] Code cleanup patches

[Andrew Azores]

Hi,

The larger two of the three attached patches do a few simple things:
1) make variables/parameters/fields final, where applicable. I feel this 
makes it more clear which variables are used eg as accumulators or will 
be returned by the method, etc. This also allows the removal of some 
local variables which were created simply to have "final versions" of 
other variables, in order for them to be captured by anonymous inner 
classes for example.
2) prefix fields with "this" in very long methods. In shorter methods it 
can remain clear that fields are fields since no declaration for that 
name can be seen, but in very long methods, it can become more confusing.
3) fix formatting. Eg remove useless comments, remove whitespace from 
"empty" lines, remove trailing whitespace

There should be no changes at all in functionality, since this is just 
cleanup and not refactoring.

The smallest patch simply removes an unneeded 'ls' that I found in a 
custom reproducer's Makefile.

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: classloader_cleanup.patch
Type: text/x-patch
Size: 78856 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140203/9f4f3c11/classloader_cleanup-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extensionjnlpsinapplet_makefile_ls.patch
Type: text/x-patch
Size: 462 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140203/9f4f3c11/extensionjnlpsinapplet_makefile_ls-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: securitydialogmessagehandler_cleanup.patch
Type: text/x-patch
Size: 8149 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140203/9f4f3c11/securitydialogmessagehandler_cleanup-0001.patch