[rfc][icedtea-web] PolicyEditor

[Jiri Vanek]

On 02/12/2014 06:23 PM, Andrew Azores wrote:
> Hi all,
>
> Attached is a patch introducing a new, simplified Policy Editor. This is to go along with the
> PolicyPanel patch from a while back. It provides a much simpler interface for editing user-level
> policy files, and also doesn't do anything evil like calling System.exit() as the existing
> PolicyTool does.
>
> Functionality-wise, the PolicyEditor class-level Javadoc explains some of the less obvious details.
> Everything should hopefully be straight forward and intuitive, though. I'm definitely open to
> suggestions on the visuals and layout, etc.
>
> ChangeLog:
> Adding PolicyEditor
> * netx/net/sourceforge/jnlp/controlpanel/PolicyPanel.java: added button
> for PolicyEditor (Simple Editor), changed button labels to Simple Editor
> and Advanced Editor (policytool). (OpenFileResult,
> testDirectoryPermssions, testFilePermissions, showReadOnlyDialog,
> showCouldNotOpenFileDialog) moved into FileUtils
> * netx/net/sourceforge/jnlp/resources/Messages.properties: added messages
> for PolicyEditor
> * netx/net/sourceforge/jnlp/util/FileUtils.java: (OpenFileResult,
> testDirectoryPermssions, testFilePermissions, showReadOnlyDialog,
> showCouldNotOpenFileDialog) moved out of PolicyPanel
> * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java: new
> class. Editor for policy files
> * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditorPermissions.java:
> new enum. Models for PolicyEditor permissions
> * tests/netx/unit/net/sourceforge/jnlp/security/policyeditor/PolicyEditorPermissionsTest.java:
> new tests
> * tests/netx/unit/net/sourceforge/jnlp/security/policyeditor/PolicyEditorTest.java:
> new tests
>
> Thanks,
>

Hi!

I have no general issues with this.Considering it was done n best mind;)
After reading it, I'm against making it separate project. I would much ratehr keep it in itew.. and 
suggestion .. add new luncher? next to itw-settings javaws.. SimplePolicyEditor?

This is ok to head, so you cna continue in run in sandbox more promptly.


J.

few notes:
	permission java.io.FilePermission "${user.home}${/}*", "read";
	permission java.io.FilePermission "${user.home}${/}*", "write";
	permission java.io.FilePermission "*", "read";
	permission java.io.FilePermission "${io.tmpdir}${/}*", "read";
	permission java.io.FilePermission "${io.tmpdir}${/}*", "write";

are granted by checkboxes which do not fully descibee them (imho) Maybew tooltip should be enough....