[PATCH] [icedtea-web] Small fixes for icedtea-web-1.4.2 tests

[Jiri Vanek]

On 02/19/2014 01:53 PM, Michal Vyskocil wrote:
> On Wed, Feb 19, 2014 at 10:31:34AM +0100, Michal Vyskocil wrote:
>> On Tue, Feb 18, 2014 at 03:19:09PM +0100, Jiri Vanek wrote:
>>> On 02/18/2014 03:12 PM, Michal Vyskocil wrote:
>>>> Hi,
>>>>
>>>> when running more regression tests, I've found two issues in upstream.
>>>> Attached patches fixes both of them. I have no idea if icedtea's
>>>> http://icedtea.classpath.org/wiki/CommitPolicy#Posting_Your_Patch rules
>>>> applies for icedtea-web. If so, please let me know and I'll rework them.
>>>>
>>>> Regards
>>>> Michal Vyskocil
>>>>
>>>
>>>
>>> Those looks ok. Only the changelog is missing. Those changes have to
>>> go also to head, where applicable. I guess all are applicable.  May
>>> you verify? Do you have push rights?
>>
>> Hi Jiri,
>>
>> As you wish - those are reworked patches with added ChangeLog entry. The
>> public keystore/mkdir patch is different between HEAD and 1.4.2 due XDG
>> change. The link patch is basically the same, differs only in ChangeLog
>> hunk.
>>
>> For HEAD (sorry, those are from git format-patch, hope that's ok):
>>      * 0001-Make-sure-that-path-to-PUBLIC_KEYSTORE-exists.patch
>>      * 0002-Put-link-flags-to-the-end-of-gcc-command-line.patch
>> For 1.4.2 (those are from quilt ...):
>>      * icedtea-web-1.4.2-mkdir.patch
>>      * icedtea-web-1.4.2-softkiller-link.patch
>
> OK an another attempt - just one patch per branch as requested ...
>
>   * icedtea-web-HEAD-test-build-fixes.patch
>   * icedtea-web-1.4.2-test-build-fixes.patch
>
> Hope that's OK now
>
> Regards
> Michal Vyskocil
>
>>
>> I don't have a push access, so please apply them on your own.
>>
>> Regards
>> Michal Vyskocil

Hi!


I have pushed both your changesets. Thanx!

Just veryfing Do not 1.4 need the same check in +mkdir -p $(PUBLIC_KEYSTORE_DIR) ; \ as head do? (
[ ! -d $(keystoredir) ] && mkdir -p $(keystoredir); \)


Thanx for contribution,
   J.