[rfc][icedtea-web] Unsigned applet security dialog abstraction

[Andrew Azores]

Hi,

Three patches here. One is just unit tests. The other two need to be 
applied together to be buildable, but are split because one is actually 
the real work patch, and the other is a lot of noisy renaming.

The goal is to make the Unsigned Applet warning dialog, which is really 
quite nice, into an abstract class, so that new dialogs can be created 
for similar purposes, but with different information displayed. Namely, 
a new Partially Signed dialog, making use of the same layout and logic, 
as well as the same "remember decision" store, etc.

"abstractions.patch" actually does this work of pulling most of the 
dialog out into an abstract parent class, and making the existing class 
into a subclass of this one in such a way that the look/feel and 
functionality are all preserved. "renames.patch" just renames a lot of 
classes that are related to this dialog, and whose names are no longer 
very accurate after the abstraction is done. "abstractions.patch" does 
contain some such renaming, however, it is much more limited. 
"tests.patch" adds unit tests intended to be able to test any such 
subclasses, although each new subclass needs to be manually added to the 
test case setup.

This is in preparation for a "new-dialog.patch" which will introduce a 
new Partially Signed Dialog, to replace the existing Not All Signed 
Dialog, using the abstract parent class pulled out of the Unsigned 
Applet Dialog.

ChangeLog:
UnsignedAppletTrustWarningPanel logic moved into new abstract parent class
AppTrustWarningPanel for reusability.
* netx/net/sourceforge/jnlp/security/AppTrustWarningDialog.java: new class
* netx/net/sourceforge/jnlp/security/AppTrustWarningPanel.java: new class
* 
netx/net/sourceforge/jnlp/security/UnsignedAppletTrustWarningPanel.java: 
major refactor into subclass of AppTrustWarningPanel
* netx/net/sourceforge/jnlp/security/SecurityDialogs.java: 
(UnsignedWarningAction) references changed to AppSigningWarningAction
* 
netx/net/sourceforge/jnlp/security/UnsignedAppletTrustWarningDialog.java: same
* 
tests/netx/unit/net/sourceforge/jnlp/security/AppTrustWarningPanelTest.java: 
new tests for AppTrustWarningPanel
* 
netx/net/sourceforge/jnlp/security/appletextendedsecurity/ExecuteUnsignedApplet.java: 
renamed, changed all references
* 
netx/net/sourceforge/jnlp/security/appletextendedsecurity/ExecuteAppletAction.java: 
(ExecuteUnsignedApplet) renamed to this
* 
netx/net/sourceforge/jnlp/controlpanel/UnsignedAppletActionTableModel.java: 
(ExecuteAppletAction) changed references
* 
netx/net/sourceforge/jnlp/controlpanel/UnsignedAppletsTrustingListPanel.java: 
(ExecuteAppletAction) changed references
* 
netx/net/sourceforge/jnlp/security/appletextendedsecurity/UnsignedAppletActionEntry.java: 
(ExecuteAppletAction) changed references
* 
netx/net/sourceforge/jnlp/security/appletextendedsecurity/UnsignedAppletTrustConfirmation.java: 
(ExecuteAppletAction) changed references
* 
netx/net/sourceforge/jnlp/security/appletextendedsecurity/impl/UnsignedAppletActionStorageExtendedImpl.java: 
(ExecuteAppletAction) changed references
* 
netx/net/sourceforge/jnlp/security/appletextendedsecurity/impl/UnsignedAppletActionStorageImpl.java: 
(ExecuteAppletAction) changed references


Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: abstraction.patch
Type: text/x-patch
Size: 30593 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140227/10bea8a5/abstraction-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: renames.patch
Type: text/x-patch
Size: 28643 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140227/10bea8a5/renames-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tests.patch
Type: text/x-patch
Size: 6053 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140227/10bea8a5/tests-0001.patch