[rfc][icedtea-web] (PR1264) Run in Sandbox button
Omair Majid
omajid at redhat.com
Fri Feb 28 12:53:24 PST 2014
* Andrew Azores <aazores at redhat.com> [2014-02-28 14:25]:
> These patches only really differ from the previous ones by
> SecurityDelegate. I'm not even sure 'delegate' is quite the right
> term for what this is - close enough? It doesn't really simplify any
> of the security decision logic, but it at least consolidates it into
> one place. There are probably other things that can be moved into
> the SecurityDelegate, but for now I've just moved stuff that I've
> personally worked on, in particular the Run In Sandbox stuff, of
> course.
You are right, it's not really buying us much. But I think it's a step
in the right direction.
A request for future patches: please dont mix refactoring (like
extracting a SecurityDelegate class) with actual changes. If there are
regressions, mixing both in one patch will make things harder to
identify and fix.
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the distro-pkg-dev
mailing list