[rfc][icedtea-web] splashscreen christmas extension
Pavel Tisnovsky
ptisnovs at redhat.com
Fri Jan 17 06:59:20 PST 2014
Hi Jiri,
this change looks correct (but review is a bit late ;) ok for head.
Just few minor fixes are needed:
+ private static final int avarage_star_width = 10; //stars will be 5-15
+ private final int avarage_fall_speed = 4; //2-6
+ private final int avarage_rotation_speed = 2; //1-3
you'd need to call:
sed -i 's/avarage/average/g' ChristmasExtension.java
+ Copyright (C) 2012 Red Hat, Inc.
^^^ should be updated, at last! :)
Cheers,
Pavel
----- Jiri Vanek <jvanek at redhat.com> wrote:
> hi!
>
> As some of you may noted, I made and christmas release of icedtea web for fedora with (similar as)
> attached patch (nothing more). I know I have break a rules a bit, but the code is moreover harmless,
> and is changing splashscreen for last 14days of an Gregorian calendar's year.
>
> The attached patch is a bit more generalised. The included interface and manager have no ambitions
> to be perfect and are moreover single purposed until some another extension come.
>
> Sorry for this surprise, and hope it will be more welcomed then not-wonted
>
> J.
More information about the distro-pkg-dev
mailing list