[rfc][icedtea-web] policytool in itweb-settings

[Andrew Azores]

On 01/17/2014 05:35 AM, Jiri Vanek wrote:
> snip
>>
>
> Ugh. It still do not work.
>
> In 000  or  222 permissions - the policy tool executed with "read 
> only" message. It should not opena at all, and correct error message 
> should apear (can not read)
>
> so  - rw - no message, open policy toool
>     - r-  - read only warning, lucnh
>     - -w or --, can not read/write, not luching
>

Apparently I had some difficulties with basic logic yesterday :D

>
> Unluckily I found one overlooked flaw - when policy tool is closed, it 
> close ITW-settiings. It should not happen.
>
> If it will be to complex* to fix, then I'm for this fix as another 
> changeset. (as I would really like this changeset (in simplest form) 
> bubble to 1.4)
>
>
> * I'm afraid You will have to owerride something or modify it via 
> reflection or use some another nasty ahck to fix it :(

This is why I was launching PolicyTool in a new process in the first 
place, actually. In all its wisdom, PolicyTool exits the JVM when its 
window closes.

>
>>>
>>> Please use File.createTmpfile(dir,pattern) instead :)
>>> It guarants you creation of the file, so you do not need to throw.
>>
>> I didn't do this in the attached new patches, because I'm not sure 
>> about it. This is going to create
>> temp files, eg in /tmp - do we really want to back up to here? If the 
>> power goes out during a test
> nope :)
>
> Se again:   File.createTmpfile(dir,pattern). You can let it crate file 
> in any dir - 
> http://docs.oracle.com/javase/7/docs/api/java/io/File.html#createTempFile%28java.lang.String,%20java.lang.String,%20java.io.File%29
>
> Pls really use this instead of your schema.

Okay, okay, you win. :)

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: custom_policy6.patch
Type: text/x-patch
Size: 13898 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140117/d76f6e2c/custom_policy6-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reproducers4.patch
Type: text/x-patch
Size: 19589 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140117/d76f6e2c/reproducers4-0001.patch