[icedtea-web] "Not All Signed" dialog and low-security setting

[Andrew Azores]

On 12/23/2013 10:28 AM, Andrew Azores wrote:
> (snip)
>
> Again, using zimbra web interface today, so formatting might be weird.
>
> I have worked on this some more and added in the signer information etc. into the dialog, and also done a little bit of extra minor refactoring (changing type names). The subclassing is also done better now (I think) and has tests. Unfortunately it got very messy when I was working on all of this and splitting up the work, so I only have the end product all together as one monolithic patch :( however I do have some older versions that are split into pieces. So the attached patch file is the full thing, and the attached tgz contains the somewhat-out-of-date smaller pieces. I can't really split the full patch into smaller pieces very well because some of the different steps required working on the same files and even the same parts of the same files.
>
> So here we have the UnsignedApplet dialog being made abstract and having its name changed, and a subclass being introduced that takes its original name and brings back identical functionality. Then we have a new subclass introduced which is the PartiallySigned dialog, and methods and enum constants are added to facilitate the use of this. There is also a unit test that tests both of these subclasses and verifies that their implementations of the parent's abstract methods make sense.
>
> Thanks,
>
> Andrew A

Update! I rebased this patch on latest head and fixed an issue where the 
new PartiallySigned dialog would appear along with the old "fully 
signed" dialog. I also split the patch up into some smaller units for 
ease of review, however they do all need to be applied at once for the 
result to actually be buildable.

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: abstraction.patch
Type: text/x-patch
Size: 32183 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140120/bc8dc241/abstraction-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: new-dialog.patch
Type: text/x-patch
Size: 13785 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140120/bc8dc241/new-dialog-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not-needed-anymore.patch
Type: text/x-patch
Size: 4974 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140120/bc8dc241/not-needed-anymore-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: renames.patch
Type: text/x-patch
Size: 30179 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140120/bc8dc241/renames-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tests.patch
Type: text/x-patch
Size: 6416 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140120/bc8dc241/tests-0001.patch