[rfc][icedtea-web] policytool in itweb-settings

Andrew Azores aazores at redhat.com
Mon Jan 20 12:11:57 PST 2014


On 01/20/2014 02:50 PM, Andrew Azores wrote:
> On 01/20/2014 07:27 AM, Jiri Vanek wrote:
>> On 01/17/2014 10:08 PM, Andrew Azores wrote:
>>> (snip)
>>
>> Ouch. See my reply to patch.
>
> Didn't see any mail, but we discussed on IRC. Here's a recap:
> - The reflection hack is horrible. It doesn't quite work, and it's 
> super ugly.
> - The process not exiting is definitely a problem. We should not be 
> playing around with reflection on the policytool like this.
> - Calling PolicyTool.main() directly breaks the automated build(?). We 
> don't want to make it a build dep, and it's too minor to bother with a 
> configure step/flag(?).
> - Solution: Runtime#exec() makes its return, with a fallback method of 
> reflectively invoking PolicyTool.main() if for any reason the exec 
> fails (non-POSIX system, executable not on PATH, etc)
>
> So here's a patch implementing this solution, with lots of extra added 
> documentation.
>

And this time with better respect for event dispatch thread, I hope. 
(thanks omajid)

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: custompolicy-exec-with-fallback2.patch
Type: text/x-patch
Size: 13510 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140120/6c016399/custompolicy-exec-with-fallback2.patch 


More information about the distro-pkg-dev mailing list