[rfc][icedtea-web] policytool in itweb-settings

Omair Majid omajid at redhat.com
Fri Jan 24 07:31:39 PST 2014


* Andrew Azores <aazores at redhat.com> [2014-01-23 16:23]:
> Anyway, moving on to the actual work at hand :-). Again, you're
> right that ProcessBuilder#start() doesn't seem to be explicitly
> defined as being asynchronous, although intuitively it seems like it
> should be. But I can't find hard facts anywhere guaranteeing this,
> and I can't really see it causing any problems to do this work
> within a new Thread (because what possible issue could there be with
> removing this work from the AWT thread? This absolutely should be
> independent of that). So in the new patch, that whole chunk of code
> is inside a new Thread.

The javadocs for `Process` [1] say:

"""
There is no requirement that a process represented by a Process object
execute asynchronously or concurrently with respect to the Java process
that owns the Process object. 
"""

Anyway, patch looks fine to me.

Thanks,
Omair

[1] http://docs.oracle.com/javase/7/docs/api/java/lang/Process.html

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


More information about the distro-pkg-dev mailing list