Bug 1435: [IcedTea7] OpenJDK 7 returns incorrect TrueType font metrics

[Yasumasa Suenaga]

Hi Andrew,

Thank you for replying.

I've booked this issue as:
   Bug 1659: [IcedTea7] OpenJDK 7 returns incorrect TrueType font metrics when bold style is set

If my patch is reviewed, I want to push this to IcedTea7 and relase/icedtea7-forest-2.4 .
So I need reviewers for this.
Could you review this ?


Thanks,

Yasumasa


On 2014/01/30 19:26, Andrew Hughes wrote:
>
>
> ----- Original Message -----
>> Hi all,
>>
>> My customer encountered this issue.
>> Status of this issue is resolved. However, if bold style is set,
>> this issue is appeared yet.
>>
>> I read source code of "freetype-2.5.0-4.fc20" .
>> Bold style should not affect FontFace. However, current implementation
>> of OpenJDK affects it to Font Glyph. Thus value of Ascent/Descent is
>> incorrect.
>>
>> I've made patch for this issue as "fontScaler.patch" which is attached
>> on this email. Could you review this ?
>>
>> This issue is also booked in JBS as JDK-8017773: OpenJDK7 returns incorrect
>> TrueType font metrics . I think my patch will be fixed this issue too.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8017773
>>
>>
>> BTW, I have few questions:
>>
>>   1. Can I reopen Bug 1435 ? Or should I book this as new issue ?
>>
>
> New issue please.
>
>>   2. I am commiter of HeapStats which is hosted in IcedTea.
>>      If my patch is reviewed, can I commit this ?
>>
>
> Yes.
>
>>   3. If answer of 2. is "Yes", where should I push this ?
>>      relase/icedtea7-forest-2.4 ?  ivedtea7 ?
>>
>
> IcedTea7 and probably 2.4 as well, but will depend on review.
>
>>   4. Can we (HeapStats committers) be a reviewer of IcedTea7 ?
>>
>
> Anyone can.
>
>>
>> Thanks,
>>
>> Yasumasa
>>
>> ------ D E T A I L S ------
>>
>> I've created testcase as "JavaApplication1.java" .
>> Result as:
>>
>> OracleJDK 6 Update 31
>> ----------------
>> [root at RHEL6-5 font]# /usr/local/jdk1.6.0_31/bin/java JavaApplication1
>> JDK: 1.6.0_31
>>      VM: Java HotSpot(TM) 64-Bit Server VM
>>
>> java.awt.Font[family=IPAMincho,name=IPAMincho,style=plain,size=50]
>>       Ascent:  43.99414
>>       Descent: 6.0058594
>>
>> java.awt.Font[family=IPA明朝,name=IPAMincho,style=bold,size=50]
>>       Ascent:  43.99414
>>       Descent: 6.0058594
>> ----------------
>>
>> OpenJDK7 (in RHEL6.5)
>> ----------------
>> [root at RHEL6-5 font]# java JavaApplication1
>> JDK: 1.7.0_45
>>      VM: OpenJDK 64-Bit Server VM
>>
>> java.awt.Font[family=IPAMincho,name=IPAMincho,style=plain,size=50]
>>       Ascent:  43.99414
>>       Descent: 6.0058594
>>
>> java.awt.Font[family=IPA明朝,name=IPAMincho,style=bold,size=50]
>>       Ascent:  45.60547
>>       Descent: 4.3945312
>> ----------------
>>
>