[rfc][icedtea-web] Decrease verbosity of resources tests was Re: [rfc][icedtea-web] Add new PL localized messages

[Jacob Wisor]

On 07/01/2014 01:52 PM, Jiri Vanek wrote:
> ,,,snip...
>
>
> Most of the tests in this group is comparing only against the main.
> The one who doeas all x all, was initially for something  a bit different then
> is now. The attached
> patch is fixing it.
>
> The patch for 1.5 is much more readable. (as do the same except cosmetic changes)
>
>
> Thank you!
>
>
> J.
>
>
>
> hmm. Looking to the patch just before the send-click. The NB did the refactoring
> of the loop, so the
> logical change is not visible.
>
> It is:
>
> -        bundles.add(main);
> ...
> - for (int j = 0; j < bundles.size(); j++) {
> -                LocalesIdentifier resourceBundle2 = bundles.get(j);
> -                if
> (resourceBundle1.getLanguage().equals(resourceBundle2.getLanguage())) {
> -                    //do not compare same language groups
> -                    allLog("Skipping same language " +
> resourceBundle1.getLocale() + " x " +
> resourceBundle2.getLocale() + " (should be " + resourceBundle1.getIdentifier() +
> " x " +

Please replace " x " with " vs. ". ;-)

> resourceBundle2.getIdentifier() + ")");
> -                    break;
> -                }
> +            LocalesIdentifier resourceBundle2 = main;
>
> only. The rest re foeach loops, diamonds and the unlucky reformanting which NB
> did, but They are
> closed now And I can not do undo :(
>
> One aditional logic change is
>
> +                if (val1.length() > 1000) {
> +                    errLog("Skipping chek of: " + key + " too long. (" +

Please fix typos in string literals.

> val1.length() + ")");
> +                    continue;
>                    }
>
> This get rid of the 12k long help line (which no one will ever translate :) )
>
> Attached are also results of those two test runs for 1.5 and head.
>
> Again, thank you very very much, feel free to use the results as informative only.
>
>
> Any changes to pl/de ( as it is now, or possible celaning) is ok to go to head+1.5

Apart from that the patch looks okay to me.

Jacob