[rfc][icedtea-web][policyeditor] Dispose on close fix

[Andrew Azores]

On 06/30/2014 04:58 PM, Jacob Wisor wrote:
> On 06/30/2014 09:38 PM, Andrew Azores wrote:
>> Hi,
>>
>> I noticed today that closing PolicyEditor via the window manager (in 
>> my case, alt-shift-q) does not properly respect the "Cancel" option 
>> on the confirmation dialog which appears if you are exiting without 
>> first saving changes. Using File>Exit or the Close button however 
>> does respect the Cancel option. The problem is that the window is 
>> being disposed due to the window manager close event, rather than 
>> letting the editor decide on its own when to dispose itself. Fixing 
>> this is as simple as removing one extra dispose() and changing the 
>> default close operation from DISPOSE_ON_CLOSE to DO_NOTHING_ON_CLOSE.
>>
>
> Look good to me... but wouldn't you like to add a "save changes 
> dialog" before closing, when PolicyEditor has not been launched by the 
> IcedTea-Web control panel?
>
> Jacob

There should be already, have you found a case where it doesn't appear?

Thanks,

-- 
Andrew A