[rfc][icedtea-web][policyeditor] Keyboard shortcuts and mnemonics touchup

[Andrew Azores]

On 07/01/2014 10:18 AM, Jacob Wisor wrote:
> On 06/30/2014 09:15 PM, Andrew Azores wrote:
>> (Sorry for the maybe not-so-good email formatting here - replying from
>> a web interface today unfortunately)
>>
>> ----- Original Message -----
>>> On 06/27/2014 05:14 PM, Andrew Azores wrote:
>>>> On 06/26/2014 03:16 PM, Andrew Azores wrote:
>>>>> Hi,
>>>>>
>>>>> This patch enhances PolicyEditor's accessibility quite a lot. Changes
>>>>> include:
>>>>>
>>>>> 1) Pressing "Enter" while a Group Checkbox has focus will expand
>>>>> the group
>>>>> (pressing space still selects the entire group at once)
>>>
>>> Oh, now I understand what you are intending to do... So you want to
>>> kind of
>>> simulate a right-click on the keyboard. Then the key should probably be
>>> KeyEvent.VK_CONTEXT_MENU instead of KeyEvent.VK_ENTER. On Windows
>>> KeyEvent.VK_CONTEXT_MENU maps to SHIFT+F10 (right-click). On other
>>> window
>>> managers KeyEvent.VK_CONTEXT_MENU should also map to right-click or some
>>> other
>>> key combination in place of a right-click, or maybe just the menu
>>> key. Try it
>>> with your window manager. This one is tricky.
>>
>> Thanks for the tip! VK_CONTEXT_MENU is a nice enhancement. I only have
>> i3 installed so I haven't tested with any other window managers
>> (anyone else reading this, please give it a shot too) but it works
>> fine here with the actual menu key. I also took your advice of
>> changing the Rename accelerator to F2 - sounds reasonable to me, and I
>> wasn't aware that there was actually a "standard" for that. Taking a
>> look at my file manager though (Thunar) I do see that same accelerator
>> listed.
>
> i3? Hard core, eh? :-D I for myself are using Mate. Speaking of which,
> it allows for almost fully configurable accelerators. ;-)

MATE is my preferred full DE, but for a while now I've just been using a 
plain window manager.

>
>> [...]
>>>
>>> This stuff may seem like details or nit picking but this is actually
>>> part of
>>> what makes good software. Going into details, tuning, making it
>>> easier and
>>> easier, making look and feel consistent with the rest of the system,
>>> etc. is
>>> what makes software such a pleasure to use. Most users do not
>>> perceive this
>>> actively but all major software packages that are heavy on UI are
>>> only so
>>> accessible and relatively easy to use because their developers spend a
>>> considerable amount of time on perfecting the UI experience. So keep on
>>> perfecting! ;-)
>>>
>>
>> I know :) that's why I keep coming back to improve PolicyEditor this
>> way. Nobody's really asked me to do these particular things, I just
>> want to make the Editor accessible and easy to use now that I've got
>> it (mostly) providing the actual functionality that it was supposed to
>> provide. Maybe I'm not getting every detail right on the first
>> attempt, but, well, everything needs to be learned for the first time
>> before it can be done right ;)
>
> Sure, that's what development cycles and iterations are for. ;-) This is
> also why I usually try to slow down people from rushing releases. There
> is really no benefit it releasing early and often. Check for bugs, do
> internal reviewing. Of course, you won't catch every bug with internal
> reviewing but will definitely get the obvious blunders. There is still
> polishing left to do on the PolicyEditor but you're on a good track.
>
> Jacob

Attached is a patch that removes one extra line that was put in for 
simple smoke testing and found its way into the last patch without being 
cleaned... :(

Thanks,
-- 
Andrew Azores
-------------- next part --------------
A non-text attachment was scrubbed...
Name: policyeditor-keybindings-4.patch
Type: text/x-patch
Size: 21756 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140702/1accb4a9/policyeditor-keybindings-4.patch>