[rfc][icedtea-web] itweb-settings Control Panel Resizing

[Jie Kang]

Hello,

> > Hello,
> >
> > I have created a patch fixing the issues outlined here:
> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1856
> >
> > The UI behaves better for lower resolutions (e.g. 800x600).
> >
> 
> Thank you for fixing this. Would you like to backport this to 1.5 too, since
> panel resizing has been broken since then (presumably by Jiri ;-) )?
> 
> Thank you also for formatting the source code.
> 
>  > +    ListCellRenderer comboRendererWithToolTips = new
>  > DefaultListCellRenderer() {
>  > +
>  > +        @Override
>  > +        public Component getListCellRendererComponent(JList<?> list,
>  > +                Object value, int index, boolean isSelected,
>  > +                boolean cellHasFocus) {
> 
> Please make getListCellRendererComponent()'s parameters final. The method
> itself
> can be made final too.
> 
>  > +            setToolTipText(value.toString());

Done.

> 
> Since getListCellRendererComponent() has a public access modifier, value can
> be
> null. For the sake of robustness please add the trinary operator here to
> check
> value for null before dereferencing it.

I have added a null-check.

> 
>  > +            return super.getListCellRendererComponent(list, value, index,
>  > isSelected,
>  > +                    cellHasFocus);
>  > +        }
>  > +
>  > +    };
>  > +
>  > [...]
>  > @@ -338,15 +361,15 @@
>  >
>  >          globalBehaviourLabel.setText(
>  >     Translator.R("APPEXTSECguiPanelGlobalBehaviourCaption"));
>  >
>  > -        deleteTypeComboBox.setModel(new
>  > javax.swing.DefaultComboBoxModel<>(new String[] {
> 
> Please beware of the "diamond" operator when backporting to 1.5. ;-)
> 

Thanks.

>  > +        deleteTypeComboBox.setModel(new DefaultComboBoxModel<>(new
>  > String[] {
>  >                      Translator.R("APPEXTSECguiPanelDeleteMenuSelected"),
>  >                      Translator.R("APPEXTSECguiPanelDeleteMenuAllA"),
>  >                      Translator.R("APPEXTSECguiPanelDeleteMenuAllN"),
>  >                      Translator.R("APPEXTSECguiPanelDeleteMenuAlly"),
>  >                      Translator.R("APPEXTSECguiPanelDeleteMenuAlln"),
>  >                      Translator.R("APPEXTSECguiPanelDeleteMenuAllAll")}));
>  > -
>  > -        viewFilter.setModel(new javax.swing.DefaultComboBoxModel<>(new
>  > String[] {
>  > +        deleteTypeComboBox.setRenderer(comboRendererWithToolTips);
>  > +        viewFilter.setModel(new DefaultComboBoxModel<>(new String[] {
> 
> Please beware of the "diamond" operator when backporting to 1.5. ;-)
> 
>  >                      Translator.R("APPEXTSECguiPanelShowOnlyPermanent"),
>  >                      Translator.R("APPEXTSECguiPanelShowOnlyTemporal"),
>  >                      Translator.R("APPEXTSECguiPanelShowAll"),
>  > [...]
>  > @@ -756,12 +779,12 @@
>  >      }
>  >
>  >      private void reloadTable() {
>  > -        List<? extends SortKey> l =
>  > currentTable.getRowSorter().getSortKeys();
>  > +        List<? extends javax.swing.RowSorter.SortKey> l =
>  > currentTable.getRowSorter().getSortKeys();
> 
> Why did you remove the import for SortKey?

I'm not sure. My bad. (can I blame Eclipse?)

> 
>  >          currentTable.setModel(new DefaultTableModel());
>  >          currentTable.setModel(currentModel);
>  >          {
>  >              currentTable.getRowSorter().setSortKeys(l);
>  > -
>  > +
>  >          }
>  >
>  >      }
> 
> Apart from that, good work! :-)


Thanks for the review. I have also included a backport patch to 1.5.

> 
> Jacob
> 


Regards,

-- 

Jie Kang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: control-panel-size-2.patch
Type: text/x-patch
Size: 20575 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140707/a150957d/control-panel-size-2-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: control-panel-size-1.5-backport.patch
Type: text/x-patch
Size: 21475 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140707/a150957d/control-panel-size-1.5-backport-0001.patch>