[rfc][icedtea-web] Console Output Encoding Fix

[Jacob Wisor]

On 07/15/2014 04:10, Jie Kang wrote:> Hello,
 >
 > This patch resolves the bug here 
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1858
 >
 > Characters such as 'ó' were not appearing in the Java Console due to the 
implementation of TeeOutputStream appending bytes to a StringBuffer in a 
byte-by-byte fashion ignoring the fact that the encodings involve multi-byte 
characters.
 >
 > Also, as far as I can tell the StringBuffer is not used by multiple threads 
and has been replaced by StringBuilder (see 
http://docs.oracle.com/javase/7/docs/api/java/lang/StringBuilder.html)

No, I would rather advise to stay with StringBuffer. There is no need for 
StringBuilder as long as TeeOutputStream is thread-safe.

Generally speaking, what this code should be doing is this:

import java.util.Arrays;
[...]
this.string.append(new String(Arrays.copyOfRange(b, off, off + len)));

Flushing on every '\n' can also be incorporated. ;-)

Furthermore, you may drop all of the initial parameter checking:

-        if (b == null) {
-            throw new NullPointerException();
-        } else if ((off < 0) || (off > b.length) || (len < 0)
-                || ((off + len) > b.length) || ((off + len) < 0)) {
-            throw new IndexOutOfBoundsException();
-        } else if (len == 0) {
-            return;
-        }
+        if (len == 0) return;

Working with these parameters will inevitably generate the correct exceptions. 
This is the beauty of RuntimeExceptions; You just do stuff and the JRE throws 
them for you. No double checking required. ;-)
Additional parameter checks in public methods are only required when they may 
have an illegal effect on the internal state of the (this) object or when you 
want to give additional information on an error to the programmer.

Jacob