[icedtea-web] RFC: Fix missing return value in non-void function

[Omair Majid]

Hi,

I was pointed to this patch on IRC. It adds a missing return value to a
non-void function in icedteanp code. It also fixes up indentation to be
a bit more sane.

It looks okay to me. Shall I go ahead and push?

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
-------------- next part --------------
diff --git a/ChangeLog b/ChangeLog
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-07-22  Fridrich Strba  <fridrich.strba at suse.com>
+
+	* plugin/icedteanp/IcedTeaPluginUtils.cc (flush_pre_init_messages):
+	Return NULL explicitly.
+
 2014-07-14  Andrew Azores  <aazores at redhat.com>
 
 	PolicyEditor mnemonics and accelerators overhaul
diff --git a/plugin/icedteanp/IcedTeaPluginUtils.cc b/plugin/icedteanp/IcedTeaPluginUtils.cc
--- a/plugin/icedteanp/IcedTeaPluginUtils.cc
+++ b/plugin/icedteanp/IcedTeaPluginUtils.cc
@@ -60,25 +60,25 @@
 static std::vector< PluginThreadCall* >* pendingPluginThreadRequests = new std::vector< PluginThreadCall* >();
 
 void *flush_pre_init_messages(void* data) {
-while (true){
-  struct timespec ts;
+  while (true){
+    struct timespec ts;
     ts.tv_sec = 1;
     ts.tv_nsec = 0;
-  nanosleep(&ts ,0);
-  if (jvm_up) {
-    while (!pre_jvm_message.empty()) {
-      pthread_mutex_lock(&debug_pipe_lock);
-      std::string  message = pre_jvm_message.front();
-      pre_jvm_message.pop();
-      pthread_mutex_unlock(&debug_pipe_lock);
-      plugin_send_message_to_appletviewer_console(message.c_str());
-      
+    nanosleep(&ts ,0);
+    if (jvm_up) {
+      while (!pre_jvm_message.empty()) {
+        pthread_mutex_lock(&debug_pipe_lock);
+        std::string message = pre_jvm_message.front();
+        pre_jvm_message.pop();
+        pthread_mutex_unlock(&debug_pipe_lock);
+        plugin_send_message_to_appletviewer_console(message.c_str());
+      }
+      flush_plugin_send_message_to_appletviewer_console();
     }
-    flush_plugin_send_message_to_appletviewer_console();
   }
-  
+  return NULL;
 }
-}
+
 void push_pre_init_messages(char * ldm){
   pthread_mutex_lock(&debug_pipe_lock);
   pre_jvm_message.push(std::string(ldm));