[rfc][icedtea-web] Console Output Encoding Fix
Jiri Vanek
jvanek at redhat.com
Mon Jul 28 14:29:45 UTC 2014
On 07/25/2014 04:15 PM, Jie Kang wrote:
> Hello,
>
>>
>> I'm happy with this patch with one execption.
>> I would actually like the part
>>
>> catch(unsupportedencodinge){
>> tostring(witoutEncoding)
>> }
>>
>> to return. BUt log the exception :)
>
>
> The newest iteration actually no longer needs this :D Jacob and Omair caught the mistakes there so thanks to them!
>
> I attached the newest one again just for easy reference.
>
>>
>> Also this should be sanitized, that the exception is thrown only once (all
>> follwing toString will
>> use no-encoding)
>>
>> Pleasestick the new path togeher with tests. With some luck next iteration
>> will be last (Unless
>> jacob/Omair complains to strongly:)
>
>
> Should the backport to 1.5 include the tests as well?
>
>
>>
>> J.
>>
>
>
> Regards!
>
Assuming it works ( :-) ) (well console worked for me, and seemd to be flushed correctly.. but I was unable to verify the bug fix... :( )
Ok to head and 1.5
J.
More information about the distro-pkg-dev
mailing list