[rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space
Jie Kang
jkang at redhat.com
Mon Jul 28 21:16:40 UTC 2014
> Hello,
>
> Here is the updated patch on the cache size spinner that addresses the bug
> PR1857. A JLabel is now present under
> the spinner to tell the user available disk size and the maximum allowable
> number for the cache size. The spinner
> also changes colour to yellow when the user goes over 0.5% of the usable disk
> space. It turns to red if the user makes the spinner go past the usable disk
> space size and changes the JLabel to display a warning. Also the cache panel
> was put into a scroll pane so that the "view files" button is not in the
> default view or when resized to smaller.
Nice patch. Just a minor nit with the import statements:
+import javax.swing.*;
+import javax.swing.event.ChangeEvent;
+import javax.swing.event.ChangeListener;
+import java.awt.*;
Instead of importing the whole library please replace these with only the imports of specific classes that you need.
>
> Thank you,
> Lukasz Dracz
>
Thanks!
--
Jie Kang
More information about the distro-pkg-dev
mailing list