[rfc][icedtea-web] Console Output Encoding Fix

Jie Kang jkang at redhat.com
Tue Jul 29 12:55:30 UTC 2014


Hello,


> On 07/25/2014 04:15 PM, Jie Kang wrote:
>  > +    //For unit testing
>  > +    protected ByteArrayOutputStream getByteArrayOutputStream() throws
>  > IOException {
>  > +        ByteArrayOutputStream copy = new ByteArrayOutputStream();
>  > +        copy.write(this.byteArrayOutputStream.toByteArray());
>  > +        return copy;
>  > +    }
> 
> Well, I am still unhappy with this approach. Why can't we use reflection to

I am unhappy as well which is why I asked for suggestions :D

> access TeeOutputStream.byteArrayOutputStream in the test? Tests usually run
> with
> no SecurityManager set or with AllPermissions granted so there should be no
> problem.

To be completely honest I have no actual work experience with reflection. I will look into this. Thanks for the suggestion.


> 
> Jacob
> 

-- 

Jie Kang


More information about the distro-pkg-dev mailing list