[rfc][icedtea-web][policyeditor] Copy Paste refactored to use System Clipboard

[Jie Kang]

----- Original Message -----
> Hello,
> 
> I have been working with Andrew A on a patch that refactors the copy and
> paste functionality to use the system clipboard. We had to refactor the
> parsing to allow it take in Strings instead of requiring a file.
> 2014-07-14  Andrew Azores  <aazores at redhat.com>
>             Lukasz Dracz  <ldracz at redhat.com>
>     * netx/net/sourceforge/jnlp/resources/Messages.properties
>     (PEClipboardError, PEInvalidPolicy, PEClipboardAccessError): added
>     * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java
>     (renameCodebaseButtonAction, copyCodebaseButtonAction,
>     pasteCodebaseButtonAction):
>     changed functionality to call methods from PolicyEditorController
>     that use system clipboard
>     *
>     netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditorController.java
>     (addPolicyEntry): added
>     (openAndParsePolicyFile): throws new exception InvalidPolicyException
>     (copyCodebaseToClipboard, getClipboardContentAsString,
>     getPolicyEntryFromClipboard,
>     getCodebaseFromClipboard, getPermissionsFromClipboard,
>     getCustomPermissionsFromClipboard): new methods
>     * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEntry.java
>     (getCodebase, getPermissions, getCustomPermissions, fromString,
>     validatePolicy): new overloaded methods
>     * netx/net/sourceforge/jnlp/security/policyeditor/PolicyFileModel.java
>     all methods made synchronized (openAndParsePolicyFile): extracted and
>     modified
>     parsing logic
>     (parsePolicyString): new method
>     (clearPermissions): also clears Custom Permissions now
>     *
>     netx/net/sourceforge/jnlp/security/policyeditor/InvalidPolicyException.java:
>     added new exception
>     * netx/net/sourceforge/jnlp/security/policyeditor/CustomPermission.java
>     (equals, hashCode): Override these methods to be able to compare custom
>     permissions.
>     New constructors for custom permission, one of the constructors takes
>     only PermissionType, PermissionTarget
>     and the other takes an additional PermissionActions
>     *
>     tests/netx/unit/net/sourceforge/jnlp/security/policyeditor/CustomPermissionTest.java,
>     *
>     tests/netx/unit/net/sourceforge/jnlp/security/policyeditor/PolicyEditorParsingTest.java,
>     *
>     tests/netx/unit/net/sourceforge/jnlp/security/policyeditor/PolicyEditorTest.java,
>     *
>     tests/netx/unit/net/sourceforge/jnlp/security/policyeditor/PolicyEditorControllerTest.java,
>     *
>     tests/netx/unit/net/sourceforge/jnlp/security/policyeditor/PolicyEntryTest.java,
>     *
>     tests/netx/unit/net/sourceforge/jnlp/security/policyeditor/PolicyFileModelTest.java:
>     added new unit tests
> 
> Thank you,
> Lukasz Dracz

Hello,


Nice patch but a few things:


I would make the error message for failing to paste a little more descriptive. Right now I see "Could not read policy entry for codebase null". I suggest something like "Paste failed: System clipboard does not contain a valid codebase entry" Or something that let's the user know that the paste failed because they are trying to copy something that isn't acceptable.

Also maybe for another patch, I would make it possible to paste one codebases' properties to another. Atm if you try to paste to a codebase that already exists, nothing happens and the dialog reappears. I think it would be good to instead have it override the properties of the existing codebase. Or have a selection to allow overriding.

When doing user testing, I repeatedly attempted to paste an invalid entry from the system clipboard. When closing the program there some exceptions spouted out which may or may not be an issue. I have attached the logs. It seems that each failure to paste from system clipboard does not fully complete until the policyeditor closes at which point it spews out it's exceptions. Something like that :/



Regards,


-- 

Jie Kang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clipboard.log
Type: text/x-log
Size: 9515 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140730/7bf56691/clipboard-0001.log>