[rfc][icedtea-web][policyeditor] "File - New"

[Jie Kang]

----- Original Message -----
> On 07/30/2014 04:01 PM, Jie Kang wrote:
> > Hello,
> >
> >> Hi,
> >>
> >> This patch adds "File - New" functionality to PolicyEditor, so a new
> >> policy file can be created/edited properly. Previously the editor would
> >> either have to be relaunched, or the current file could be saved and
> >> then the contents changed for the new file and "Save As" used to put it
> >> in the correct location.
> >>
> >
> > I would add ellipses to the other names that open new dialogs. E.g.
> > 'Open...', the ellipses could also be applied to 'Add new'., etc.
> >
> 
> Done, thanks.
> 
> >
> >> This patch also makes the window title dynamic, so that it shows the
> >> currently open file's path (if any), and also an asterisk if any changes
> >> have been made in the editor since the file was opened or last saved.
> >
> > Nice :D
> >
> >  From my testing, removing a codebase doesn't cause changesMade to be set
> >  to true. e.g. add codebase, save, remove codebase : state should be
> >  changesMade=true, but no * is shown in UI.
> >
> 
> Nice catch, fixed in the attached patch.
> 
> >
> > I notice that if you check something permission it will be set to * to show
> > changes made, but if you uncheck it, it remains as *. This functionality
> > differs from other programs I think. This is probably because the
> > change-checking mechanism doesn't save the base-state and compare with it
> > to see changes made. Maybe for a future patch this could be implemented.
> >
> 
> Yea, the changes-made checking is just so primitive right now that this
> isn't really feasible. That feature would probably be extremely easy to
> implement if PolicyEditor were to ever be given undo/redo support, for
> example, but otherwise I think it'll just stay how it is.
> 

Maybe Lukas or I can look into improving it later :D

Patch looks good to me. +!

> >
> >
> >
> >>
> >> Thanks,
> >>
> >> --
> >> Andrew A
> >>
> >>
> >
> > Regards,
> >
> >
> 
> Thanks,
> --
> Andrew A
> 

-- 

Jie Kang