[rfc][icedtea-web] prevent CCE from plugin appeltviewer

[Andrew Azores]

On 07/31/2014 10:03 AM, Jiri Vanek wrote:
> On 07/31/2014 03:36 PM, Jie Kang wrote:
>>>
>>>
>>> ok for head and 1.5 ?
>>>
>>>
>>> J.
>>>
>> Hello,
>>
>>
>> Good catch!
>>
>> I think now that we check for CCE, we should output something to let 
>> us know that the CCE occurred since behaviour is affected.
>>
>> Also for the following code:
>>
>>
>> +                if (panel.getAppletClassLoader() instanceof 
>> JNLPClassLoader) {
>> +                    JNLPClassLoader loader = (JNLPClassLoader) 
>> panel.getAppletClassLoader();
>>
>> -                URL localURL = null;
>> -                if (loader.resourceAvailableLocally(resourceName)) {
>> -                    url = loader.getResource(resourceName);
>> +                    URL localURL = null;
>> +                    if 
>> (loader.resourceAvailableLocally(resourceName)) {
>> +                        url = loader.getResource(resourceName);
>> +                    }
>> +
>> +                    url = localURL != null ? localURL : url;
>>                   }
>> -
>> -                url = localURL != null ? localURL : url;
>>
>>
>> I think that the behaviour of the function changed a little. If a CCE 
>> occurs, the AppletImageRef returned is that of url that includes 
>> codebase. Is this valid? I think if CCE occurs then we should return 
>> null.
>>
>>
>
> +
>
> > What happens in the first hunk if the appletClassLoader isn't a 
> JNLPClassLoader?
>
>
>
> The url will have its default value and if this is invalid, then it 
> will die alter. BUt in most cases it will work.
>
>
> J.

Well, it can't be any more fatal than an uncaught ClassCastException. +1 
push 1.5 and HEAD from me.

Thanks,

-- 
Andrew A