[rfc][icedtea-web] Temporary Permissions as check boxes

[Andrew Azores]

On 06/02/2014 10:09 AM, Lukasz Dracz wrote:
>
> ----- Original Message -----
>> From: "Andrew Azores" <aazores at redhat.com>
>> To: "Lukasz Dracz" <ldracz at redhat.com>, distro-pkg-dev at openjdk.java.net
>> Sent: Monday, June 2, 2014 9:36:30 AM
>> Subject: Re: [rfc][icedtea-web] Temporary Permissions as check boxes
>>
>> On 05/30/2014 04:44 PM, Lukasz Dracz wrote:
>>> Hello,
>>>
>>> I have changed the Temporary Permissions menu items into check box menu
>>> items, and changed up the behaviour to take this into account. Adding the
>>> set of permissions happens when a check box is selected and removed when
>>> not, to a new temporary Permissions collection. When the user is satisfied
>>> with the selection of temporary permissions they have chosen, they press
>>> sandbox which is when the new temporary Permissions collection gets
>>> applied like the old way.
>>> A planned future patch is to restructure the temporary permissions into
>>> categories and presets that would make better sense under this check box
>>> concept.
>>>
>>> Changelog:
>>> 2014-05-30  Lukasz Dracz  <ldracz at redhat.com>
>>>
>>>           Changed Temporary Permissions from menu items to check box menu
>>>           items
>>>           *
>>>           netx/net/sourceforge/jnlp/security/dialogs/TemporaryPermissionsButton.java
>>>           (TemporaryPermissionsListener.actionPerformed): Added behaviour to
>>>           add
>>>           or remove permissions from a new collection of permissions based
>>>           on
>>>           whether the item is checked or not
>>>           (TemporaryPermissionsButton.TemporaryPermissionsButton): Added
>>>           action
>>>           listener and applied the new collection of permissions for when
>>>           the
>>>           sandbox button is pressed
>>>
>>>
>>> Thank you,
>>> Lukasz Dracz
>> I think you forgot an attachment.
>>
>> Thanks,
>>
>> --
>> Andrew A
>>
>>
> Hello,
>
> Yes I did, thank you for reminding me and sorry for the inconvenience.
> I have attached the mentioned patch to this email.
>
> Thank you
> Lukasz D

+                temporaryPermissions.addAll((Collection<? extends Permission>) permissions);

Is the cast here necessary? Please remove it if not. Otherwise, this 
looks good.

Thanks,

-- 
Andrew A