[rfc][icedtea-web] Temporary Permissions as check boxes

Andrew Azores aazores at redhat.com
Tue Jun 3 13:49:18 UTC 2014


On 06/03/2014 09:32 AM, Lukasz Dracz wrote:
>
> ----- Original Message -----
>> +                temporaryPermissions.addAll((Collection<? extends
>> Permission>) permissions);
>>
>> Is the cast here necessary? Please remove it if not. Otherwise, this
>> looks good.
>>
>> Thanks,
>>
>> --
>> Andrew A
>>
>>
> Hello,
>
> Your right the cast was unnecessary and I have removed it.
> The changed patch is attached.
>
> Thank you,
> Lukasz Dracz
>

Looks good, I'll push this for you now.

One nit-pick is the ChangeLog - the new ChangeLog entry should be at the 
top, not inserted between two others. But I'll fix this for you.

Thanks,

-- 
Andrew A



More information about the distro-pkg-dev mailing list