[rfc][icedtea-web] PluginMessage test time zone

[Omair Majid]

* Lukasz Dracz <ldracz at redhat.com> [2014-06-03 10:24]:
> I was looking into why CreatePluginHeaderTestOk was failing and found
> that when PluginMessage parses the date field in its constructor it
> would grab the time correctly but convert it to the user's timezone
> when it was being retrieved for the unit testing. I added a date
> variable that would parse the same date outside of PluginMessage to
> ensure that the test wasn't dependent on the user's time zone.

An alternative is to explicitly set (and then restore) the locale using
Locale.setDefault() in a @Before (and restore in an @After) method. This
ensures the test always sees the same locale, irrespective of the system
locale. If you are dealing with timestamps, this is often an easier
approach to use.

> +++ b/tests/netx/unit/net/sourceforge/jnlp/util/logging/JavaConsoleTest.java	Tue Jun 03 10:18:24 2014 -0400

> +        Date localized = new Date();
> +        localized.setTime(new SimpleDateFormat("EEE MMM dd HH:mm:ss ZZZ yyyy").parse(TEST_TIME).getTime());

Why not just:

     Date localized = new SimpleDateFormat(...).parse(...)

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681