[rfc][icedtea-web] PolicyEditor NPE-on-save fix

Omair Majid omajid at redhat.com
Tue Jun 3 15:01:46 UTC 2014


* Andrew Azores <aazores at redhat.com> [2014-06-03 10:58]:
> It *can* be done, and I've done it in the attached patch, but the type
> safety starts getting a bit questionable since a Window is needed in some
> places and a PolicyEditorWindow in others. Maybe it could be done with a bit
> better type safety by breaking it into several helpers rather than one large
> one though, but at that point it's going to end up being duplicated helper
> calls anyway.

Maybe you can make the comment less verbose? :)

Anyway, patch looks okay to me.

Cheers,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


More information about the distro-pkg-dev mailing list