[rfc][icedtea-web] PolicyEditor empty entries save to file

[Lukasz Dracz]

----- Original Message -----
> From: "Andrew Azores" <aazores at redhat.com>
> To: "Jie Kang" <jkang at redhat.com>
> Cc: "IcedTea" <distro-pkg-dev at openjdk.java.net>
> Sent: Tuesday, June 3, 2014 4:50:28 PM
> Subject: Re: [rfc][icedtea-web] PolicyEditor empty entries save to file
> 
> Oh, turns out the old patch also doesn't cleanly apply to HEAD anymore. I've
> attached an updated version which does, and also does a little cleanup
> (ensuring that a FileLock is released).
> 
> Thanks.
> 
> ----- Original Message -----
> > Hello,
> > 
> > ----- Original Message -----
> > > On 05/27/2014 09:22 AM, Andrew Azores wrote:
> > > > On 05/21/2014 11:54 AM, Andrew Azores wrote:
> > > >> Hi,
> > > >>
> > > >> This patch makes it so that "empty" codebase entries (those with no
> > > >> permissions applied to them) will still be written to the policy
> > > >> file, so that on re-open, the "empty" codebase is still present. A
> > > >> special exception is added for the default "All Applets" codebase,
> > > >> since it always appears in the editor anyway and it doesn't make
> > > >> sense to have a persistent empty entry in that case.
> > > >>
> > > >> For example:
> > > >> 1) policyeditor -file .config/icedtea-web/security/java.policy
> > > >> 2) add a new codebase which isn't already present, eg
> > > >> http://example.com
> > > >> 3) save the file
> > > >> 4) $EDITOR config/icedtea-web/security/java.policy - verify the empty
> > > >> "grant codeBase http://example/com" block is present
> > > >> 5) policyeditor -file .config/icedtea-web/security/java.policy -
> > > >> verify the example.com codebase appears and has no permissions applied
> > > >>
> > > >> ChangeLog:
> > > >>
> > > >> Empty codebase entries in PolicyEditor are saved to file
> > > >> * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java
> > > >> (savePolicyFile): fileLock made final, enabledPermissions declaration
> > > >> moved closer to usage
> > > >> * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEntry.java
> > > >> (toString): add codebase.isEmpty() condition to returning empty
> > > >> string result
> > > >>
> > 
> > The patch looks fine. 0.5 from me :)
> > 
> > 
> > Regards,
> > 
> > Jie
> > 
> 

Hello,

The patch looks great to me. 0.5 from me as well.

Thank you,
Lukasz Dracz