[rfc][icedtea-web][policyeditor] Enhancement: added Rename, Copy, and Paste actions

[Jie Kang]

Hello,

----- Original Message -----
> On 06/03/2014 06:24 PM, Andrew Azores wrote:
> > On 05/30/2014 03:19 PM, Andrew Azores wrote:
> >> Hi,
> >>
> >> As alluded to in the subject, this patch adds three new actions to
> >> PolicyEditor. They are all available through the new Edit menu. The
> >> Rename action allows a codebase entry to be renamed, keeping all of
> >> the same permissions. The Copy and Paste actions can be used to
> >> duplicate the permissions of one codebase and grant them to a new
> >> codebase, which makes it easier to produce two codebase entries with
> >> very similar permissions granted.
> >>
> >> This patch also fixes a bug where removing a codebase only did so for
> >> the standard permissions map which models the checkboxes in the main
> >> PolicyEditor UI, but did not remove custom permissions granted to the
> >> codebase through CustomPolicyViewer. There are also some very minor
> >> refactors included, noted in the in-patch ChangeLog.
> >>
> >> Thanks,
> >>

Code analysis: it looks okay 

When running manual tests everything works as expected. Unit tests on my machine also have no new failures. I will run integration tests as well later on.


My one recommendation would be to separate Data and View a little more (e.g. atm copy/paste/rename are only exposed through GUI but should probably be standalone that GUI 'connects' to). Maybe also consider making Codebases their own class/object. Otherwise looks good.


> >
> > Attached is an updated version that applies cleanly to HEAD.
> >
> > Still not included are key accelerators or mnemonics for the new menu
> > items. I'm going to go through and redo all of them in a later patch.
> >
> > Thanks,
> >
> 
> Very slight update. I noticed that the Rename action didn't ensure that
> a codebase wasn't renamed to an already existing other codebase, which
> would allow the already existing codebase to be deleted in favour of the
> newly renamed one. This is solved just by checking if the desired rename
> is already present in another codebase entry and, if so, re-prompting
> for a codebase name.
> 
> Thanks,
> 
> --
> Andrew A
> 
> 


Regards,

Jie