[rfc][icedtea-web] Refactor of LiveConnect Tests Version 2

[Andrew Azores]

On 06/04/2014 02:59 PM, Jie Kang wrote:
> Hello,
>
> This patch refactors the LiveConnect Tests and also modifies the Makefile.am in order to allow for shared resources to be used during test runs. E.g. the refactored tests all use the same function located in file JSTest.js. This is located in tests/shared/resources and when dist-tests are run, there is a new stamp compile-copy-shared-resources.stamp that is created that also moves the files in the shared folder into the appropriate folder for test runs. This currently works for reproducer tests and may be expanded on in the future.
>
>
> Regards,
>
> Jie Kang
>
> ----- Original Message -----
>> Hello,
>>
>> This patch refactors the majority of LiveConnect Tests (JS to Java and
>> vice-versa) fixing the race condition between asynchronous JS and the
>> J-applet. Code format is standardized and deprecated code usage is
>> removed/replaced. Note that the file JSTest.js is duplicated for all
>> LiveConnect Tests. This is because every single test requires the same
>> function in JSTest.js to prevent the race condition from occurring. However,
>> the test suite is not designed to easily have this code appear only once
>> while also having tests be properly separate (ie. every single test-case
>> should be able to run by itself without relying on another test case). If
>> anyone has any suggestions on how to better implement this please say.
>>
>>
>> Thanks,
>>
>> Jie Kang

I haven't looked over the whole patch yet, but as far as the Makefile 
changes go the first thing I notice is that your new stamp's name is a 
bit confusing. Why does it contain the word 'compile'? For example, look 
at the stamp name 'copy-reproducers-resources'. Perhaps this new stamp 
can be called just 'copy-shared-reproducers-resources' instead?

+	cp -r "$(REPRODUCERS_SHAREDSRCDIR)/resources/"* $(REPRODUCERS_TESTS_SERVER_DEPLOYDIR)/shared/  ; \


Is there a particular reason that you have the asterisk outside of the 
quotes in that first argument? Not wrong, just a little strange. 
Secondly, you should probably quote the entire second argument. What 
happens to your stamp right now if REPRODUCERS_TESTS_SERVER_DEPLOYDIR 
gets redefined such that its name contains a space?

I don't know if Omair had anything in particular in mind for this 
"shared resources" directory but this looks like it's on the right track 
to me.

Thanks,

-- 
Andrew A

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140605/587291d1/attachment-0001.html>