[rfc][icedtea-web][policyeditor] CustomPolicyEditor method extractions and tests added

[Lukasz Dracz]

----- Original Message -----
> From: "Andrew Azores" <aazores at redhat.com>
> To: "IcedTea" <distro-pkg-dev at openjdk.java.net>
> Sent: Friday, June 6, 2014 10:49:38 AM
> Subject: Re: [rfc][icedtea-web][policyeditor] CustomPolicyEditor method	extractions and tests added
> 
> On 06/06/2014 10:47 AM, Andrew Azores wrote:
> > Hi,
> >
> > In the same vein as the previous patch to PolicyEditor which extracted
> > some methods to allow unit testing, this attached patch does the same
> > for CustomPolicyViewer. Additionally, CustomPolicyViewer no longer
> > holds a reference of its own to the PolicyFileModel, instead using
> > appropriate methods exposed through its parent PolicyEditor.
> > CustomPolicyViewer now also uses CustomPolicy.fromString() rather than
> > its own "parsing" solution, and also no longer allows duplicate
> > permissions to be added to the user interface (which was a bug since
> > the actual collection modelling this is a Set anyway, so the JList and
> > Set could become out of sync).
> >
> > Thanks,
> >
> 
> Sorry, in the subject line that should be CustomPolicy*Viewer*, not
> CustomPolicyEditor.
> 
> Thanks,
> 
> --
> Andrew A
> 
> 

Hello,

The functionality works on stopping repeats but adding Custom Permissions now require a more strict format, i.e. the tool-tip mentions not to include the word permission when setting a permission but I found it necessary to do so to be able to add a custom permission. Perhaps changing the tool tip or if it is possible making the user not need to enter the word permission, or have a semi-colon at the end. Other than that it looks good.

Thank you,
Lukasz Dracz