[rfc][icedtea-web][policyeditor] CustomPolicyEditor method extractions and tests added

[Lukasz Dracz]

> Hello,
> 
> > > Yea, I wasn't too happy with it either. The adding of a permission on
> > > its own is not enough to extract into a method, it needs to be done
> > > along with the asserts to be anything useful. I don't want to have the
> > > asserts in a non- at Test method really, so what's left is either calling
> > > a test from within other tests, or just having duplicate code. The
> > > attached patch lets the duplicate code be rather than calling another
> > > @Test method from within tests.
> > >
> 
> I think the duplicate code is okay in this situation. I noticed this issue is
> also in PolicyEditorTest.java where testClearCustomPermission calls
> testAddCustomPermission. I think we should have duplicate code here too.
> Otherwise looks good.
> 

Hello,

The patch looks good. Looking over the duplicated code, I think it is fine and helps in a way with
the readability of the code. +0.5.

> > > Thanks,
> > >
> > 
> > Ping.
> > 
> > Thanks,
> > 
> > --
> > Andrew A
> > 
> > 
> 
> --
> Jie Kang
> 

Thanks,
Lukasz Dracz