[rfc][icedtea-web][policyeditor] Reduced usage of weak references

[Omair Majid]

* Andrew Azores <aazores at redhat.com> [2014-06-11 14:57]:
> Anyway, patch attached has weakThis renamed to parentPolicyEditor.
> showCouldNotSaveDialog also uses it for the same reason that
> showChangesSavedDialog does, since I noticed that it had also been changed
> to use PolicyEditor.this even though this dialog can also appear the same
> way after the editor has been disposed. The comment explaining the use of
> the weak reference also says it prevents JVM exit, not GC.

I think you forgot to update the comment. It still talks about GC:
 
> +++ b/netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java

>      private void showChangesSavedDialog() {
> +        // This dialog is often displayed when closing the editor, and so PolicyEditor
> +        // may already be disposed when this dialog appears. Give a weak reference so
> +        // that this dialog doesn't prevent GC of the editor

>      private void showCouldNotSaveDialog() {
> +        // This dialog is often displayed when closing the editor, and so PolicyEditor
> +        // may already be disposed when this dialog appears. Give a weak reference so
> +        // that this dialog doesn't prevent GC of the editor

Feel free to push.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681