[rfc][icedtea-web] Refactor of LiveConnect Tests Version 2

[Jiri Vanek]

On 06/17/2014 05:28 PM, Andrew Azores wrote:
> On 06/12/2014 03:58 PM, Jie Kang wrote:
>> Hello,
>>
>>> I ran the reproducer suite with this patch applied last night. There are
>>> still some tests which are failing but not marked as KnownToFail. I
>>> haven't checked if these failures are repeatable however. Can you look
>>> into this?
>>>
>>> JavascriptSetTest - AppletJToJSSet_2DArrayElement_Test
>>> JSToJFuncResolTest - AppletJSToJFuncResol_inheritedClassToParent1_Test
>>> JavascriptFuncReturnTest -
>>> AppletJToJSFuncReturn_{number,boolean,JSObject,String,Object}_Test
>>>
>> I've checked the failures and fixed the FuncReturn test cases (typo).
>>
>> The JavascriptSetTest has some weird behaviour where the failure occurs because the applet's init
>> method didn't print out "applet initialized". This failure does not happen very often at all and I
>> will look into it.
>>
>> The JSToJFuncResolTest failure has been marked Known to Fail. I've checked the test and found
>> another bug in the LiveConnect code unrelated to the fixes made in this patch. I have prepared
>> another patch that fixes this bug and will send it after this patch.
>>
>> Thanks for the review!
>>> Thanks,
>>>
>>> --
>>> Andrew A
>>>
>>>
>> --
>> Jie Kang
>
> Just ran the tests, everything appears to be sorted out now.
>
> I'll wait before pushing to see if Jiri is strongly objecting to the "shared" resources folder,
> otherwise, I think this is good to go.
Unluckily, yes, I'm still a bit against. I probably do not understand the usecase "lunch one reproducer"

When I'm running one reproducer, then I allow it in whitelist, and then engine prepare *all* 
reproducers, from which my one is lunched.

My mine reason against the explicit shared resources is, that actually also freshly prepared 
(compiled!) signed,  custom and simple reproducers can be shared with each other.

I Really think adding special case to copy some special resources is misleading from point of above 
sentence.

I do not wot to block this much longer, so please chat about it today evening all three of us.

Sorry for disagreeing,
  J.