[rfc][icedtea-web] ConsoleOutputPane formatting fix & cleanup

[Jie Kang]

----- Original Message -----
> On 06/20/2014 04:29 PM, Jacob Wisor wrote:
> > Hello!
> >
> > While localizing I needed to look up some code in order to understand the
> > semantics of some
> > messages. This cought my attention on ConsoleOutputPane. So, I provide some
> > some formatting and typo
> > fixes for ConsoleOutputPane.
> >
> > Thank you for reviewing!
> >
> > Jacob
> >
> > p.s.: There are still some easy to fix UI inconsistencies. ;-)
> hi!
> 
> Thanx for reformating.
> 
> 
> Most of the fixes looks ok.
> 
> I have found no logic change, I hope i have not missed some.
> 

I read/tested the patch as well and I see no glaring logic change either, though I can't rule out missing some edge case.

> Well Although instanceof is null-proof, I like to have it more visible by
> explicit != null. But this
> nvm.
> 
> 
> The only change against which I have - just personal  - objections is the
> move of initComponents'
> declarations to constructor. I can see that you did it to allow variables to
> become final. But is it
> really worthy?
> 
> 
> Except that, and except I overlooked some change in logic, ok to for head.
> 
> For the final+constructor and non-final/separate method  I would like to hear
> third party voice. Or
> yours :)


I think non-final/separate is okay for future code-reuse, but in this case, I prefer 'final' since these components are definitely final components. It is more 60% prefer, not really 90% or 100% prefer though since the change is so slight.


> 
> Thank you!
> 
> 
> J.
> 
> ps - sorry for not (yet) checking the PL localization. The tests are
> complaining for
> missing/redundant keys both for PL and DE, but I had no spare cycle to move
> to ITW machine :(
> 

-- 
--
Jie Kang