[rfc][icedtea-web] LiveConnect Method Overload Resolver Fix

Adam Domurad domuradical at gmail.com
Mon Jun 23 15:57:03 UTC 2014


On Mon, Jun 23, 2014 at 11:51 AM, Jie Kang <jkang at redhat.com> wrote:
>
>
> ----- Original Message -----
>> I just skimmed it, but it looks good to me. Only small nit is that
>> lowestDistance is not always strictly true since lowestCost is the
>> first criteria.
>
> You are right about this but I can't think of a better name for it. Any suggestions?;;

Sorry, I should have added that I had no suggestions :-). It's good as is.

>
>
> I've also made a small fix to the function: classDistance
> The while loop is no longer while(true) and is better code.

Looks good to me.

-Adam


More information about the distro-pkg-dev mailing list