[rfc][icedtea-web][policyeditor] Parent-window searching fix
Omair Majid
omajid at redhat.com
Tue Jun 24 19:20:42 UTC 2014
* Andrew Azores <aazores at redhat.com> [2014-06-24 15:13]:
> If the Javadoc on this method is to be trusted then the semantics are
> identical, and it seems to work fine anyway.
Use the source :)
It looks exactly the same.
> - if (c == null) {
> - return;
> - }
> + final Window w = SwingUtilities.getWindowAncestor(PolicyEditor.this);
Just one nit: if the parent is null, the previous code returned without
doing anything. getWindowAncestor can also return null, which we should
handle identically.
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the distro-pkg-dev
mailing list