[rfc][icedtea-web] Move all security dialogues' panels implementation into separate subpackage.

Jiri Vanek jvanek at redhat.com
Tue Mar 4 04:56:13 PST 2014


On 02/26/2014 02:59 PM, Jiri Vanek wrote:
> Move all security dialogues' panels implementation into separate subpackage.
>
> The dialogues are really multiplying, and the package of net/sourceforge/jnlp/security/ is overrun.
> This refactoring is moving all implementations of security dialogues' panels into
> net/sourceforge/jnlp/security/dialogues/
>
> The only real change of code is
>
>
> -    protected void setValue(Object value) {
> +    public void setValue(Object value) {
>           OutputController.getLogger().log("Setting value:" + value);
>           this.value = value;
>       }
>
> in netx/net/sourceforge/jnlp/security/SecurityDialog.java
>
> Which seems tome better then move netx/net/sourceforge/jnlp/security/SecurityDialog.java to
> netx/net/sourceforge/jnlp/security/dialogues/SecurityDialog.java
>
> If somebody cares, this patch is applicable also to 1.4 but backports to Panes are not common. Is
> anybody for/against the refactoring of 1.4 too?
>
> Best regards from CZ
>    J.

ping?

The dialogues multiply....
Now I'm even in mode to move all AppTrustWarningPanel derived panels to separate subpackage too...

J.


More information about the distro-pkg-dev mailing list