[rfc][icedtea-web] save runn urls to property

[Jiri Vanek]

On 03/05/2014 05:33 PM, Omair Majid wrote:
> Hi,
>
> * Jiri Vanek<jvanek at redhat.com>  [2014-03-05 11:16]:
>
>> diff -r 0a36108ce4b9 netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java
>
>> +    /*urls lunching this application*/
>> +    private static String history = "";
>
>> +    public static void saveHistory(String documentBase) {
>> +        //java-abrt-connector can print out specific application String field, it is good to save visited urls for reproduce purposes
>> +        //for javaws we can read the destination jnlp from commandline
>> +        //hoever for plugin (url arrive via pipes)? Also for plugin ve can not be sure which opened tab/window
>> +        //have casued the crash,. Thats why the individual urls are added, not repalced.
>
> Would it make more sense to put this comment on the field? If I am
> trying to find the reason for existence of a field, I am more likely to
> look at the field first than the code that touches it.

Sure.
>
>> diff -r 0a36108ce4b9 plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
>
>>                               "Height = ", height, "\n",
>>                               "DocumentBase = ", documentBase, "\n",
>>                               "Params = ", paramString);
>> +        JNLPRuntime.saveHistory(documentBase);
>>
>>           PluginAppletPanelFactory factory = new PluginAppletPanelFactory();
>>           AppletMessageHandler amh = new AppletMessageHandler("appletviewer");
>
> Will this work correctly when multiple applets are initializing? Is
> thread safety something we have to consider?
>

Well. It is handled in message consumer thread. So it should be perfectly safe.
But I would guess synchronised keyword for saveHistroy will not harm if you insists.

J.