[rfc][icedtea-web] clean button for console
Andrew Azores
aazores at redhat.com
Tue Mar 11 13:56:20 UTC 2014
On 03/11/2014 09:29 AM, Jiri Vanek wrote:
> 2014-03-11 Jiri Vanek <jvanek at redhat.com>
>
> * netx/net/sourceforge/jnlp/resources/Messages.properties: added
> (ButClean)
> key for new button
> * netx/net/sourceforge/jnlp/util/logging/ConsoleOutputPane.java:
> (update)
> method enhanced for possibility to force refresh
> * netx/net/sourceforge/jnlp/util/logging/JavaConsole.java: added
> ButClean
> button. (updateModel) overlaoded with force attribute.
Seems generally okay. One thing:
> + if ( arg!= null && arg instanceof Boolean && ((Boolean)arg).booleanValue()) {
"arg instanceof Boolean" will already give false if arg == null, so the
arg != null check isn't really necessary. But you can keep it if you
find it more readable leaving it in place.
Thanks,
--
Andrew A
More information about the distro-pkg-dev
mailing list