[rfc][icedtea-web] implemented Application-Library-Allowable-Codebase Attribute
Jiri Vanek
jvanek at redhat.com
Fri Mar 14 13:24:06 UTC 2014
On 03/13/2014 08:05 PM, Andrew Azores wrote:
> On 03/13/2014 02:43 PM, Andrew Azores wrote:
>> On 03/11/2014 03:25 PM, Jiri Vanek wrote:
>>> All your nits have been fixed. However:
>>>
>>> I'm still not using the AppTrustWarningPanel, so rember button is useless. It will come as
>>> another changeset (if ever)
>>> - this patch broke elluminate - one of the deadly throws is probably redundant and should be
>>> repalced by security prompt.
>>
>> Not okay to push if elluminate is broken by this... have you figured out what to do about it?
>>
>>> - jsut hint - download indicator is broken
>>> - elluminat works, but freaze to, same as http://www.walter-fendt.de/ph14e/resultant.htm
>>>
>>> I guess all above are older issues not related to this patch.
>>>
>>>
>>> J.
>>>
>>
>> Thanks,
>>
>
> Apparently it was just a broken cache problem. Elluminate does work.
>
> One nit was left unfixed:
>
>> + URL documentBase = null;
>> + if (file instanceof PluginBridge) {
>> + documentBase = ((PluginBridge) file).getSourceLocation();
>> + }
>> + if (documentBase == null) {
>> + documentBase = file.getCodeBase();
>> + }
>
I have kept it as it was. I think there can be state, when (PluginBridge) file).getSourceLocation()
will really remian null. But codebase is never null.
J.
More information about the distro-pkg-dev
mailing list