AArch64 updates for icedtea7-forest

Andrew Haley aph at redhat.com
Tue Mar 18 16:11:13 UTC 2014


On 03/18/2014 04:09 PM, Andrew Hughes wrote:
> ----- Original Message -----
>> All pretty straightforward, and hopefully uncontroversial.
>>
>> Andrew.
>>
>>
> 
> How did you generate this file?
> 
> There's some clear duplication here:
> 
> diff -r d6953869315d -r 90cda5cd2340 make/common/shared/Platform.gmk
> --- a/make/common/shared/Platform.gmk	Mon Mar 17 17:17:43 2014 +0000
> +++ b/make/common/shared/Platform.gmk	Mon Mar 17 17:56:51 2014 +0000
> @@ -227,6 +227,9 @@
>        ifeq ($(ARCH), aarch64)
>          ARCH_DATA_MODEL=64
>        endif
> +      ifeq ($(ARCH), aarch64)
> +        ARCH_DATA_MODEL=64
> +      endif
>      endif
>    endif
> 
> repeating what was done earlier in the patch.

Strange.  I'll have another look.

> Also:
> 
> diff -r d6953869315d -r 90cda5cd2340 make/javax/sound/SoundDefs.gmk
> --- a/make/javax/sound/SoundDefs.gmk	Mon Mar 17 17:17:43 2014 +0000
> +++ b/make/javax/sound/SoundDefs.gmk	Mon Mar 17 17:56:51 2014 +0000
> @@ -134,6 +134,10 @@
>      CPPFLAGS += -DX_ARCH=X_AMD64
>    endif # ARCH amd64
>  
> +  ifeq ($(ARCH), aarch64)
> +    CPPFLAGS += -DX_ARCH=X_AARCH64
> +  endif # ARCH amd64
> +
>    ifeq ($(ARCH), arm)
>      CPPFLAGS += -DX_ARCH=X_ARM
>    endif # ARCH arm
> 
> was already added by PR1551: Add build support for Zero AArch64.

Even stranger.

> It's not clear why this is 3 separate changesets when one would suffice.

It's a workflow thing: these are separate patches from upstream,
written at different times.

I'll have a look and adjust as appropriate.

Andrew.




More information about the distro-pkg-dev mailing list