/hg/icedtea-web: PolicyEditor IO operations made synchronous

[aazores at icedtea.classpath.org]

changeset ca18850addad in /hg/icedtea-web
details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=ca18850addad
author: Andrew Azores <aazores at redhat.com>
date: Wed Mar 26 12:07:23 2014 -0400

	PolicyEditor IO operations made synchronous

	* netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java:
	(savePolicyFile, openAndParsePolicyFile) made synchronous so that
	programmatically adding a new codebase has a well-defined order when
	performed immediately after starting a new PolicyEditor instance


diffstat:

 ChangeLog                                                         |  7 +++++++
 netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java |  8 ++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diffs (39 lines):

diff -r fcb9dcf1c83c -r ca18850addad ChangeLog
--- a/ChangeLog	Wed Mar 26 11:02:00 2014 -0400
+++ b/ChangeLog	Wed Mar 26 12:07:23 2014 -0400
@@ -1,3 +1,10 @@
+2014-03-26  Andrew Azores  <aazores at redhat.com>
+
+	* netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java:
+	(savePolicyFile, openAndParsePolicyFile) made synchronous so that
+	programmatically adding a new codebase has a well-defined order when
+	performed immediately after starting a new PolicyEditor instance
+
 2014-03-26  Andrew Azores  <aazores at redhat.com>
             Jiri Vanek  <jvanek at redhat.com>
 
diff -r fcb9dcf1c83c -r ca18850addad netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java
--- a/netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java	Wed Mar 26 11:02:00 2014 -0400
+++ b/netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java	Wed Mar 26 12:07:23 2014 -0400
@@ -1067,7 +1067,9 @@
                     OutputController.getLogger().log(e);
                 }
             }
-        }.start();
+        }.run(); // #run() to make IO synchronous right now. #start() can be used to make it async instead.
+        // http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2014-March/026886.html
+        // TODO: use SwingWorker and give some visual indication that IO is occurring
     }
 
     /**
@@ -1170,7 +1172,9 @@
                     showCouldNotSaveDialog();
                 }
             }
-        }.start();
+        }.run(); // #run() to make IO synchronous right now. #start() can be used to make it async instead.
+        // http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2014-March/026886.html
+        // TODO: use SwingWorker and give some visual indication that IO is occurring
     }
 
     /**