[icedtea-web] RFC: Minor fixes to ALACA dialog

[Omair Majid]

Hi,

The attached patches does some minor tweaks to the ALACA dialog.

1. The word 'codebase' is removed. It seems redundant; the text reads
about as well without it.

2. The list of urls is now enclosed within a html unordered-list
element. Not enclosing it makes the parser think that the last list
element is not terminated and causes the text after the list ("Are you
sure...") to be indented.

I am also thinking of making more changes, but I would like some
feedback before doing those:

I would also like to reword the dialog some more to something like this:

'''
The application 'Foo' from 'Bar' uses resources from the following urls:
- http://example.com
- http://example.org

Are you sure you want to run this application?
'''

I am not sure the ALACA reference that is currently present is adding
any more information. It may not have any meaning to users.

Also, would it make more sense to change the "For more information"
links to read "Manifest Attributes" and "Preventing RIAs from Being
Repurposed" rather than the raw html links? At least for me, the links
are so wide that they do not fix in the dialog and get cut off.

Thoughts?

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
-------------- next part --------------
diff --git a/netx/net/sourceforge/jnlp/resources/Messages.properties b/netx/net/sourceforge/jnlp/resources/Messages.properties
--- a/netx/net/sourceforge/jnlp/resources/Messages.properties
+++ b/netx/net/sourceforge/jnlp/resources/Messages.properties
@@ -62,8 +62,8 @@
 
 # missing Application-Library-Allowable-Codebase dialogue
 ALACAMissingMainTitle=Application <span color='red'> {0} </span> \
-form codebase <span color='red'> {1} </span> is missing the  Application-Library-Allowable-Codebase attribute. \
-This application uses resources from the following remote locations:<br/> {2} Are you sure you want to run this application?
+from <span color='red'> {1} </span> is missing the  Application-Library-Allowable-Codebase attribute. \
+This application uses resources from the following remote locations: {2} Are you sure you want to run this application?
 ALACAMissingInfo=For more information you can visit:<br/>\
 <a href="http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/security/manifest.html#app_library"> \
 http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/security/manifest.html#app_library</a> <br/> \
diff --git a/netx/net/sourceforge/jnlp/util/UrlUtils.java b/netx/net/sourceforge/jnlp/util/UrlUtils.java
--- a/netx/net/sourceforge/jnlp/util/UrlUtils.java
+++ b/netx/net/sourceforge/jnlp/util/UrlUtils.java
@@ -195,9 +195,11 @@
      */
     public static String setOfUrlsToHtmlList(Iterable<URL> remoteUrls) {
         StringBuilder sb = new StringBuilder();
+        sb.append("<ul>");
         for (URL url : remoteUrls) {
             sb.append("<li>").append(url.toExternalForm()).append("</li>");
         }
+        sb.append("</ul>");
         return sb.toString();
     }