[icedtea-web] RFC: change download window to a jdialog

[Omair Majid]

* Andrew Azores <aazores at redhat.com> [2014-05-02 16:55]:
> On 05/02/2014 04:48 PM, Andrew Azores wrote:
> >On 05/02/2014 04:34 PM, Omair Majid wrote:
> >>The attached patch makes it a JDialog so it's treated as a dialog and
> >>it's size and position are respected.
> >>
> >There are other places that we should probably consider making
> >this change as well. For example, the "could not launch" dialog.
> >Reproducer - just hit cancel on the security prompt for Elluminate
> >or something. At least with i3, that error dialog also appears to
> >actually be a frame and is treated as a new application window.
> >Likewise, the ITW splash screen does the same, although perhaps
> >this one should be treated as an application window? Would you
> >care to investigate those as well and roll it up into one patch
> >since it's all probably the same thing over again? If not, then
> >feel free to just push this one alone (with backport too probably)
> >and the rest can just be fixed separately.
> 
> Hmm my mistake, the splash screen actually doesn't do that, I had
> remembered its issue incorrectly. Rather than filling the entire
> window, it actually shows up incredibly small! So that's probably a
> different fix required. The error dialog I think is the same though.

I looked at the error dialog (BasicExceptionDialog), and it's a
different case. It's already a JDialog; it's the call to
`JDialog.setResizable(true)` that somehow makes the window manager treat
it like a JFrame.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681