[icedtea-web] RFC: clean up comments in JarFile
Jiri Vanek
jvanek at redhat.com
Tue May 13 12:52:35 UTC 2014
On 05/13/2014 12:17 AM, Omair Majid wrote:
> Hi,
>
> I saw some references to jdk6 in JarFile and to me it read like it's
> saying that this wrapper is effectively making java.util.jar.JarFile a
> Closeable. So, I wanted to remove this file (since we dropped OpenJDK 6
> compatibility).
>
> On looking at the file history, it turns out I was completely mistaken.
> This class protects against GIFAR attacks. To avoid someone else messing
> this up accidentally, I fixed up the comments (and made some other minor
> changes to reduce the need for comments).
>
I must say I'm not 100% sure why you do wont this thing, but looks generally ok.
Few more such a changes (like comments and similar stuff) and soon no backport will be possible from head to 1.5 ....
Feel free to push.
J.
More information about the distro-pkg-dev
mailing list