/hg/icedtea-web: Properly disconnect all connected http connecti...

[Jiri Vanek]

On 05/12/2014 11:03 PM, Omair Majid wrote:
<snip>

Hi!

I have followed your advices and tried to fix add meaningful comments.

I have one more opinion to the final I have added.  If somebody will suddenly try to assign to final 
value, he will be warned by compiler. And thats good thing. At least it will force him to double 
check what he is doing.

I have also followed your recommendation to move few util classes to UrlUtils. And write tests for them.

There is one change in code then. The original notNullUrlEquals ignored port! I added port check to 
new code. (this is actually code logic and to not belongs here..)

  I will NOT push this line (unless it is approved directly).

If you wont me to push some changes separately, I will do so.We can then continue reviewing rest of 
the patch.

Thank you!
J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: javadocCleaning2.patch
Type: text/x-patch
Size: 46179 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140515/8bdc9ad0/javadocCleaning2-0001.patch>