[rfc][icetea-web] Resource Setter/Getter Refactoring

Jiri Vanek jvanek at redhat.com
Tue May 20 13:02:53 UTC 2014


On 05/17/2014 02:29 AM, Omair Majid wrote:
> Hi,
>
> Thanks for the patch!
>

I have not read the patch. But one general hint.

Before crating getter, and especially setter, try to figure out if it is needed at all.

If not, then it can be good practice  to change the variable to be final.

And anyway, welcome to the team and goo d luck to survive us!

Best regards from CZ
    J.



More information about the distro-pkg-dev mailing list